[giampaolo/psutil] Fix possible double close and use of unopened socket (#825)

On line 407, I assume the code should jump to error if either value is -1 or python error-ed, and not when both. According to http://ift.tt/1O1Tkg2, Upon successful completion, socket() shall return a non-negative integer, the socket file descriptor. Otherwise, a value of -1 shall be returned and errno set to indicate the error.. Thus on line 540, 0 is a valid socket fd - and the check should be against -1 If py_retlist > 1, i.e Py_BuildValue returned an error, the code will jump to error and double close the socket. You can view, comment on, or merge this pull request online at:   http://ift.tt/1XRy93u Commit Summary Fix possible double close and use of unopened socket File Changes M psutil/_psutil_linux.c (9) M psutil/arch/bsd/freebsd.c (2) Patch Links: http://ift.tt/1U7RzuZ http://ift.tt/1XRy8g5 —You are receiving this because you are subscribed to this thread.Reply to this email directly or view it on GitHub

Source: Gmail -> IFTTT-> Blogger